New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: `go install -buildmode=c-shared std` does nothing #13234

Open
crawshaw opened this Issue Nov 13, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@crawshaw
Contributor

crawshaw commented Nov 13, 2015

Should it? The similar command go install -buildmode=shared std works.

cc @ianlancetaylor

@crawshaw crawshaw added this to the Go1.6 milestone Nov 13, 2015

@mwhudson

This comment has been minimized.

Contributor

mwhudson commented Nov 16, 2015

What do you think it should do?

@crawshaw

This comment has been minimized.

Contributor

crawshaw commented Nov 16, 2015

It could either exit with an error, or build the standard library with the relevant codegen args the go tool uses with -buildmode=c-shared. Silently doing nothing is odd.

@gopherbot

This comment has been minimized.

gopherbot commented Nov 16, 2015

CL https://golang.org/cl/16928 mentions this issue.

crawshaw added a commit to golang/mobile that referenced this issue Nov 16, 2015

cmd/gomobile: build android stdlib
Second attempt at the change reverted in golang.org/cl/16917.

The current code executes go install -buildmode=c-shared std, which
does nothing. (See golang/go#13234.)

Correctly compiling packages for android arm requires different
flags on Go 1.5 and 1.6, as we now build PIC. So we look for go1.5
in the output of "go version", and otherwise assume 1.6+.

Change-Id: If636f52be5019bd179483b8735630a98e6f8d201
Reviewed-on: https://go-review.googlesource.com/16928
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

@rsc rsc modified the milestones: Unplanned, Go1.6 Dec 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment