Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: invalid method "" #13311

Closed
nathan-osman opened this issue Nov 18, 2015 · 3 comments
Closed

net/http: invalid method "" #13311

nathan-osman opened this issue Nov 18, 2015 · 3 comments
Assignees
@bradfitz
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@nathan-osman
Copy link

@nathan-osman nathan-osman commented Nov 18, 2015

The documentation for http.Request clearly states:

"For client requests an empty string means GET."

However, when I attempt to make an HTTP request (using http.DefaultClient.Do()) with Method set to an empty string, I wind up with the following error:

net/http: invalid method ""

Details

$ go version
go version devel +6bf794a Wed Nov 18 19:00:45 2015 +0000 linux/amd64
@nathan-osman

This comment has been minimized.

Sign in to view
Copy link
Author

@nathan-osman nathan-osman commented Nov 18, 2015

Seems like this bug was introduced in this commit: a734a85.
@bradfitz bradfitz self-assigned this Nov 18, 2015
@bradfitz bradfitz added this to the Go1.6 milestone Nov 18, 2015
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Contributor

@bradfitz bradfitz commented Nov 18, 2015

Whoops, thanks. Sent https://go-review.googlesource.com/16952
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Nov 18, 2015

CL https://golang.org/cl/16952 mentions this issue.
@bradfitz bradfitz closed this in e4a1acc Nov 19, 2015
@golang golang locked and limited conversation to collaborators Nov 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bradfitz bradfitz

Labels
FrozenDueToAge
Projects
None yet
Milestone
  Go1.6
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@nathan-osman @bradfitz @gopherbot
You can’t perform that action at this time.