New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile: Permissions are needed in AndroidManifest.xml file #13342

Open
ghost opened this Issue Nov 20, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@ghost

ghost commented Nov 20, 2015

Many native Golang features are not usable without specifying permissions in AndroidManifest.xml. Suggest to put permissions by the time each package is imported, for example:

add the following permission when package "os" is imported:
< uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" / >

and add the following permission when package "net" is imported:
< uses-permission android:name="android.permission.INTERNET" / >

@rakyll

This comment has been minimized.

Member

rakyll commented Nov 23, 2015

I proposed the idea of automatically adding android.permission.INTERNET if net package is imported a while ago but it is considered too aggressive. There is no easy way to determine if the application is going to make an external connection.

The same rationale applies to the os package. Maybe it is easier to mark storage related functions in the scope of os.

/cc @crawshaw @hyangah

@rakyll rakyll added this to the Unreleased milestone Nov 23, 2015

@gopherbot gopherbot added the mobile label Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment