Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/oracle: 'implements' query needs to inspect all packages in the analysis scope #13457

Open
alandonovan opened this issue Dec 2, 2015 · 0 comments
Labels
Milestone

Comments

@alandonovan
Copy link
Contributor

@alandonovan alandonovan commented Dec 2, 2015

The implements query inspects only the query package and its forward transitive closure, but users expect (and the documentation states) that it will report all related types in the analysis scope. Thus a query at bufio.Reader will report io.Reader, but a query at io.Reader will not report *bufio.Reader.

This is mostly likely a regression due to commit b28839e in March.

The implements query should load all necessary packages in the analysis scope. It may be profitable to skip type-checking of all function bodies that do not contain a type declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.