Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/cmd/oracle: 'implements' query needs to inspect all packages in the analysis scope #13457
The implements query inspects only the query package and its forward transitive closure, but users expect (and the documentation states) that it will report all related types in the analysis scope. Thus a query at bufio.Reader will report io.Reader, but a query at io.Reader will not report *bufio.Reader.
This is mostly likely a regression due to commit b28839e4 in March.
The implements query should load all necessary packages in the analysis scope. It may be profitable to skip type-checking of all function bodies that do not contain a type declaration.