Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestHandlerPanicNil_h2 failing #13555

Closed
bradfitz opened this issue Dec 9, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@bradfitz
Copy link
Member

commented Dec 9, 2015

TestHandlerPanicNil_h2 (TestHandlerPanic in http2 mode) fails.

Fix.

Marking test skipped for now.

@bradfitz bradfitz self-assigned this Dec 9, 2015

@bradfitz bradfitz added this to the Go1.6 milestone Dec 9, 2015

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2015

Also TestHandlerPanic_h2

@gopherbot

This comment has been minimized.

Copy link

commented Dec 9, 2015

CL https://golang.org/cl/17683 mentions this issue.

bradfitz added a commit that referenced this issue Dec 10, 2015

net/http: run more tests in http2 mode
Failing ones are marked skipped.

Fixes #13543 (was just a test issue)
Updates #13555 (to be fixed later)
Updates #13556 (to be fixed later)
Updates #13557 (to be fixed later)
Fixes bug in golang.org/cl/17428 (http1 now uses HTTP status 431, not 413)

Change-Id: I8f7431fee35f2fc081cfe2c232ae75a00800a60b
Reviewed-on: https://go-review.googlesource.com/17683
Reviewed-by: Blake Mizerany <blake.mizerany@gmail.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Burcu Dogan <jbd@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Dec 15, 2015

CL https://golang.org/cl/17824 mentions this issue.

@gopherbot

This comment has been minimized.

Copy link

commented Dec 15, 2015

CL https://golang.org/cl/17823 mentions this issue.

bradfitz added a commit to golang/net that referenced this issue Dec 15, 2015

http2: catch panics server-side, respect RST_STREAM on the Transport …
…side

Tests in https://go-review.googlesource.com/#/c/17683/5/src/net/http/serve_test.go:
TestHandlerPanicNil_h2 and TestHandlerPanic_h2, to be re-enabled
after the copy to the main repo.

Updates golang/go#13555 (fixes the bug after the copy to the main repo)

Change-Id: I7aa3e55fb21b576ea4f94c7ed41d1ebd750ef951
Reviewed-on: https://go-review.googlesource.com/17823
Reviewed-by: Ian Lance Taylor <iant@golang.org>

@bradfitz bradfitz closed this in d4df6f4 Dec 15, 2015

@golang golang locked and limited conversation to collaborators Dec 14, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.