Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestTransportAndServerSharedBodyRace_h2 is failing #13556

Closed
bradfitz opened this issue Dec 9, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@bradfitz
Copy link
Member

commented Dec 9, 2015

I'm making TestTransportAndServerSharedBodyRace_h2 skip for now, but it's failing. Sometimes it requires a few runs:

$ go test -v -run=TestTransportAndServerSharedBodyRace -count=20
=== RUN   TestTransportAndServerSharedBodyRace_h1
--- PASS: TestTransportAndServerSharedBodyRace_h1 (0.50s)
=== RUN   TestTransportAndServerSharedBodyRace_h2
--- PASS: TestTransportAndServerSharedBodyRace_h2 (0.04s)
=== RUN   TestTransportAndServerSharedBodyRace_h1
--- PASS: TestTransportAndServerSharedBodyRace_h1 (0.50s)
=== RUN   TestTransportAndServerSharedBodyRace_h2
2015/12/09 22:15:36 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *tls.Conn 0xc8204d2600 127.0.0.1:58273 in state active

@bradfitz bradfitz self-assigned this Dec 9, 2015

@bradfitz bradfitz added this to the Go1.6 milestone Dec 9, 2015

@gopherbot

This comment has been minimized.

Copy link

commented Dec 9, 2015

CL https://golang.org/cl/17683 mentions this issue.

bradfitz added a commit that referenced this issue Dec 10, 2015

net/http: run more tests in http2 mode
Failing ones are marked skipped.

Fixes #13543 (was just a test issue)
Updates #13555 (to be fixed later)
Updates #13556 (to be fixed later)
Updates #13557 (to be fixed later)
Fixes bug in golang.org/cl/17428 (http1 now uses HTTP status 431, not 413)

Change-Id: I8f7431fee35f2fc081cfe2c232ae75a00800a60b
Reviewed-on: https://go-review.googlesource.com/17683
Reviewed-by: Blake Mizerany <blake.mizerany@gmail.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Burcu Dogan <jbd@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2016

Fix: https://golang.org/cl/18288 (and then need to bundle it into std)

bradfitz added a commit to golang/net that referenced this issue Jan 7, 2016

http2: fix Transport cancelation problems
The Transport code wasn't always sending a RST_STREAM to the server
in a few cases, and was also forgetting to flush its buffer.

I believe each part of this change was part of making golang/go#13556
not flaky. No additional tests at the moment;
TestTransportAndServerSharedBodyRace_h2 is pretty comprehensive as-is,
at least for an integration test. I should probably add some
finer-grained tests in the future.

Updates golang/go#13556

Change-Id: Ie824202b20ba6ee85b20edeeee86ec977e6daeb2
Reviewed-on: https://go-review.googlesource.com/18288
Reviewed-by: Andrew Gerrand <adg@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Jan 7, 2016

CL https://golang.org/cl/18289 mentions this issue.

@bradfitz bradfitz closed this in 67fa797 Jan 7, 2016

@golang golang locked and limited conversation to collaborators Jan 7, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.