Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: TestClientTrailers_h2 is failing #13557
Closed
Comments
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/17683 mentions this issue. |
bradfitz
added a commit
that referenced
this issue
Dec 10, 2015
Failing ones are marked skipped. Fixes #13543 (was just a test issue) Updates #13555 (to be fixed later) Updates #13556 (to be fixed later) Updates #13557 (to be fixed later) Fixes bug in golang.org/cl/17428 (http1 now uses HTTP status 431, not 413) Change-Id: I8f7431fee35f2fc081cfe2c232ae75a00800a60b Reviewed-on: https://go-review.googlesource.com/17683 Reviewed-by: Blake Mizerany <blake.mizerany@gmail.com> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Burcu Dogan <jbd@google.com> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/17891 mentions this issue. |
bradfitz
added a commit
to golang/net
that referenced
this issue
Dec 16, 2015
Updates golang/go#13557 Change-Id: I95bbb15d9abbbbc4dc6c3a22cd965d8dcef53fb8 Reviewed-on: https://go-review.googlesource.com/17891 Reviewed-by: Blake Mizerany <blake.mizerany@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/17895 mentions this issue. |
bradfitz
added a commit
that referenced
this issue
Dec 16, 2015
The old test was in client_test.go but was a mix of four things: - clients writing trailers - servers reading trailers - servers writing trailers - clients reading trailers It definitely wasn't just about clients. This moves it into clientserver_test.go and separates it into two halves: - servers writing trailers + clients reading trailers - clients writing trailers + servers reading trailers Which still isn't ideal, but is much better, and easier to read. Updates #13557 Change-Id: I8c3e58a1f974c1b10bb11ef9b588cfa0f73ff5d9 Reviewed-on: https://go-review.googlesource.com/17895 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Blake Mizerany <blake.mizerany@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/17931 mentions this issue. |
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/17930 mentions this issue. |
bradfitz
added a commit
to golang/net
that referenced
this issue
Dec 17, 2015
Tests in the main go repo. Updates golang/go#13557 Change-Id: Ide7be9e24b603008faf9f3ea55e936b86ea1c42b Reviewed-on: https://go-review.googlesource.com/17930 Reviewed-by: Blake Mizerany <blake.mizerany@gmail.com>
mk0x9
pushed a commit
to mk0x9/go
that referenced
this issue
Dec 17, 2015
…ient tests This CL updates the bundled copy of x/net/http2 to include https://golang.org/cl/17930 and enables the previously-skipped tests TestTrailersServerToClient_h2 and TestTrailersServerToClient_Flush_h2. It also updates the docs on http.Response.Trailer to describe how to use it. No change in rules. Just documenting the old unwritten rules. (there were tests locking in the behavior, and misc docs and examples scattered about, but not on http.Response.Trailer itself) Updates golang#13557 Change-Id: I6261d439f6c0d17654a1a7928790e8ffed16df6c Reviewed-on: https://go-review.googlesource.com/17931 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Blake Mizerany <blake.mizerany@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/17935 mentions this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
TestClientTrailers_h2 is marked skipped for now.
Fix.