Skip to content

runtime: underflow causes all proportional sweeping to happen at once #13589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aclements opened this issue Dec 11, 2015 · 1 comment
Closed

runtime: underflow causes all proportional sweeping to happen at once #13589

aclements opened this issue Dec 11, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@aclements
Copy link
Member

While debugging BinaryTree17 in #13535, I found that reimburseSweepCredit is underflowing mheap_.spanBytesAlloc early in the sweep cycle, which causes the next deductSweepCredit to sweep all remaining pages, rather than the small (and proportional) number it's supposed to.
@aclements aclements self-assigned this Dec 11, 2015
@aclements aclements added this to the Go1.6 milestone Dec 11, 2015
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/17745 mentions this issue.

@golang golang locked and limited conversation to collaborators Dec 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.6
Development

No branches or pull requests
2 participants
@aclements @gopherbot