$ go test -cover
--- FAIL: TestClientWrites_h2 (0.00s)
client_test.go:578: Get request did 8 Write calls, want 1
client_test.go:587: Post request did 3 Write calls, want 1
FAIL
coverage: 78.6% of statements
exit status 1
FAIL net/http 23.081s
Run 2:
$ go test -cover
--- FAIL: TestClientWrites_h2 (0.01s)
client_test.go:578: Get request did 8 Write calls, want 1
FAIL
coverage: 78.5% of statements
exit status 1
h1 and h2 have different write patterns. This test was locking in a certain behavior for the h1 client.
It's true that the h2 client does more writes than it needs to in some cases (less buffering) for simplicity, but I wasn't planning on investigating whether it's worth fixing until after Go 1.6.
bradfitz
changed the title
net/http: testClientWrite in http2 mode is broken
x/net/http2: investigate client write buffering
Dec 12, 2015
testClientWrite in http2 mode with CL https://go-review.googlesource.com/#/c/17751/1 fails, but the fails aren't that consistent
Run 1:
Run 2:
The diff that produced this is
The text was updated successfully, but these errors were encountered: