Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: "Read ""; want Hello" failure #13626

Closed
aclements opened this issue Dec 15, 2015 · 3 comments
Closed

net/http: "Read ""; want Hello" failure #13626

aclements opened this issue Dec 15, 2015 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.6

Comments

@aclements
Copy link
Member

@aclements aclements commented Dec 15, 2015

Commit 9025408 introduced TestCancelRequestMidBody_h2 in net/http, which is failing frequently on linux-amd64-noopt with:

--- FAIL: TestCancelRequestMidBody_h2 (0.00s)
    clientserver_test.go:452: Read ""; want Hello
FAIL
FAIL    net/http    11.721s

Current failures:

$ greplogs -l -md -dashboard -e 'Read ""; want Hello'
2015-12-15T00:43:53-9025408/linux-amd64-noopt
2015-12-15T04:48:33-9b1068a/linux-amd64-noopt
2015-12-15T06:43:35-3540376/linux-amd64-noopt
2015-12-15T16:15:38-6383fb6/linux-amd64-noopt
2015-12-15T16:15:59-4ad64ca/linux-amd64-noopt
2015-12-15T16:16:08-87d939d/linux-amd64-noopt

@rakyll @bradfitz
@aclements aclements added this to the Go1.6 milestone Dec 15, 2015
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Contributor

@bradfitz bradfitz commented Dec 15, 2015

This is very bizarre.

I don't expect any flakiness out of that test, and I don't see it anywhere else (or on my machine with even 1000+ iterations).

Can I blame the noopt code generation or something?
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Contributor

@bradfitz bradfitz commented Dec 15, 2015

Sent https://go-review.googlesource.com/17825
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Dec 15, 2015

CL https://golang.org/cl/17825 mentions this issue.
@bradfitz bradfitz closed this in 479c47e Dec 15, 2015
@golang golang locked and limited conversation to collaborators Dec 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
  Go1.6
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@aclements @bradfitz @gopherbot
You can’t perform that action at this time.