Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: ScaleValue fails to scale value with "gb" unit #13654

Closed
methane opened this issue Dec 17, 2015 · 0 comments
Closed

cmd/pprof: ScaleValue fails to scale value with "gb" unit #13654

methane opened this issue Dec 17, 2015 · 0 comments
Milestone

Comments

@methane
Copy link
Contributor

@methane methane commented Dec 17, 2015

https://github.com/golang/go/blob/master/src/cmd/pprof/internal/report/report.go#L1501-L1511

    case "megabyte", "mb":
        value *= 1024 * 1024
    case "gigabyte", "gb":
        value *= 1024 * 1024

Last line should be value *= 1024 * 1024 * 1024.

@bradfitz bradfitz added this to the Go1.6 milestone Dec 17, 2015
@bradfitz bradfitz closed this in 7688f0d Dec 17, 2015
@golang golang locked and limited conversation to collaborators Dec 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.