Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: http2 Transport doesn't know about 100-continue response headers #13659

Closed
bradfitz opened this issue Dec 17, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

commented Dec 17, 2015

the http2 Transport needs to know about 100-continue headers.

There can actually be 3 HTTP response HEADERS for a stream: 100-continue, the real headers, then the trailers.

/cc @bmizerany

@bradfitz bradfitz added this to the Go1.6 milestone Dec 17, 2015

@gopherbot

This comment has been minimized.

Copy link

commented Dec 17, 2015

CL https://golang.org/cl/17982 mentions this issue.

bradfitz added a commit that referenced this issue Dec 17, 2015

net/http: document ResponseWriter and Handler more; add test
Update docs on ResponseWriter and Handler around concurrency.

Also add a test.

The Handler docs were old and used "object" a lot. It was also too
ServeMux-centric.

Fixes #13050
Updates #13659 (new issue found in http2 while writing the test)

Change-Id: I25f53d5fa54f1c9d579d3d0f191bf3d94b1a251b
Reviewed-on: https://go-review.googlesource.com/17982
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@rsc

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2016

@bradfitz, what's left after CL 17982? Is it still on the table for Go 1.6?

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Jan 6, 2016

I think this one's relatively easy. I'm working on debugging #13556 at the moment and then I'll switch to this one.

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2016

Working on this one now.

@gopherbot

This comment has been minimized.

Copy link

commented Jan 7, 2016

CL https://golang.org/cl/18370 mentions this issue.

bradfitz added a commit to golang/net that referenced this issue Jan 7, 2016

http2: make Transport ignore 100-continue responses, add comprehensiv…
…e tests

This makes the Transport ignore 100-continue responses from servers,
rather than get confused by them. This is good enough for
golang/go#13659. I filed golang/go#13851 to do better later, but
that's less important.

This CL also adds comprehensive tests for the 36 different ways that
frames can be arranged from servers when reading a response. That
exposed some bugs (now fixed), and even affected the http2 API: I'd
added a END_STREAM accessor on CONTINUATION frames, but it's not even
valid there.

I also renamed some confusing variables which sounded too similar.

Updates golang/go#13659
Updates golang/go#13851

Change-Id: I58868a27258981267f1b2043f711f50a42ec744a
Reviewed-on: https://go-review.googlesource.com/18370
Reviewed-by: Andrew Gerrand <adg@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Jan 7, 2016

CL https://golang.org/cl/18371 mentions this issue.

@bradfitz bradfitz closed this in 305b4ba Jan 7, 2016

@golang golang locked and limited conversation to collaborators Jan 7, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.