Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: docs for http2 appears in package documentation #13668

Closed
ericchiang opened this issue Dec 18, 2015 · 3 comments
Closed

net/http: docs for http2 appears in package documentation #13668

ericchiang opened this issue Dec 18, 2015 · 3 comments
Milestone

Comments

@ericchiang
Copy link

@ericchiang ericchiang commented Dec 18, 2015

The h2_bundle.go file doesn't remove the "http2" package documentation string here.

See the bottom of the package documentation at https://tip.golang.org/pkg/net/http/

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Dec 18, 2015

hah! Good find, thanks.

Alan, can you add a flag to x/tools/cmd/bundle like --break_pkg_doc which adds a newline before the package statement? Otherwise I can do it manually in my wrapper script.

/cc @alandonovan

@bradfitz bradfitz added this to the Go1.6 milestone Dec 18, 2015
@adonovan

This comment has been minimized.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Jan 6, 2016

CL https://golang.org/cl/18269 mentions this issue.

@bradfitz bradfitz closed this in a4f27c4 Jan 6, 2016
@golang golang locked and limited conversation to collaborators Jan 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.