Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: Transport should de-UTF-8 hostname in Host header #13686
Comments
bradfitz
self-assigned this
Dec 18, 2015
bradfitz
added this to the Go1.6 milestone
Dec 18, 2015
This comment has been minimized.
This comment has been minimized.
|
@bradfitz which file/lines should this test be added to reproduce it? Or even the link, please? |
This comment has been minimized.
This comment has been minimized.
|
We've lived a long time without this. We don't need to rush it into Go 1.6. Let's figure it out for Go 1.7. It's a huge topic. |
rsc
modified the milestones:
Go1.7Early,
Go1.6
Jan 6, 2016
bradfitz
modified the milestones:
Go1.8Early,
Go1.7Early
May 5, 2016
This comment has been minimized.
This comment has been minimized.
|
Didn't happen for 1.7. |
This comment has been minimized.
This comment has been minimized.
|
Brad, is this NeedsFix or NeedsDecision? Still for Go 1.8? |
This comment has been minimized.
This comment has been minimized.
|
I did IDNA/Punycode already for Go 1.8. This was fixed by https://golang.org/cl/29072 (git rev b7e5303) |
bradfitz
closed this
Sep 26, 2016
Kegsay
referenced this issue
Jan 18, 2017
Closed
RSS: feed including ä in domain cannot be added #145
golang
locked and limited conversation to collaborators
Sep 26, 2017
gopherbot
added
the
FrozenDueToAge
label
Sep 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
bradfitz commentedDec 18, 2015
From golang-nuts, a test was failing in Go 1.6 against httptest.Server because of a unit test line:
{"http://Doppel.Gänger/foo_Bar-Foo", []byte(`T€st Cont€nt 123`), false},I suspect the http client is sending the "ä" as literal UTF-8 bytes in the Host header, not as punycode or whatever.