Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Transport should de-UTF-8 hostname in Host header #13686

Closed
bradfitz opened this issue Dec 18, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@bradfitz
Copy link
Member

commented Dec 18, 2015

From golang-nuts, a test was failing in Go 1.6 against httptest.Server because of a unit test line:

    {"http://Doppel.Gänger/foo_Bar-Foo", []byte(`T€st Cont€nt 123`), false},

I suspect the http client is sending the "ä" as literal UTF-8 bytes in the Host header, not as punycode or whatever.

@bradfitz bradfitz self-assigned this Dec 18, 2015

@bradfitz bradfitz added this to the Go1.6 milestone Dec 18, 2015

@odeke-em

This comment has been minimized.

Copy link
Member

commented Dec 19, 2015

@bradfitz which file/lines should this test be added to reproduce it? Or even the link, please?

@rsc

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2016

We've lived a long time without this. We don't need to rush it into Go 1.6. Let's figure it out for Go 1.7. It's a huge topic.

@rsc rsc modified the milestones: Go1.7Early, Go1.6 Jan 6, 2016

@bradfitz bradfitz modified the milestones: Go1.8Early, Go1.7Early May 5, 2016

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented May 5, 2016

Didn't happen for 1.7.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2016

Brad, is this NeedsFix or NeedsDecision? Still for Go 1.8?

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2016

I did IDNA/Punycode already for Go 1.8. This was fixed by https://golang.org/cl/29072 (git rev b7e5303)

@bradfitz bradfitz closed this Sep 26, 2016

@golang golang locked and limited conversation to collaborators Sep 26, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.