Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: std lib tests fail w/o x/net/http2 installed #13688

Closed
griesemer opened this issue Dec 18, 2015 · 3 comments
Closed

go/types: std lib tests fail w/o x/net/http2 installed #13688

griesemer opened this issue Dec 18, 2015 · 3 comments
Assignees
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Dec 18, 2015

Investigate.

$ go test -run Stdlib
--- FAIL: TestStdlib (5.75s)
    stdlib_test.go:196: /Users/gri/go/src/net/http/h2_bundle.go:3304:2: invalid operation: sc.hpackDecoder (variable of type *golang.org/x/net/http2/hpack.Decoder) has no field or method SetEmitFunc
    stdlib_test.go:196: /Users/gri/go/src/net/http/h2_bundle.go:3377:2: invalid operation: sc.hpackDecoder (variable of type *golang.org/x/net/http2/hpack.Decoder) has no field or method SetEmitFunc
    stdlib_test.go:196: /Users/gri/go/src/net/http/h2_bundle.go:4908:3: invalid operation: rl.hdec (variable of type *golang.org/x/net/http2/hpack.Decoder) has no field or method SetEmitFunc
    stdlib_test.go:196: /Users/gri/go/src/net/http/h2_bundle.go:4910:3: invalid operation: rl.hdec (variable of type *golang.org/x/net/http2/hpack.Decoder) has no field or method SetEmitFunc
FAIL
exit status 1

May be as simple as providing build.AllowVendor when calling build.Import in go/internal/gcimporter/gcimporter.go.

@griesemer griesemer self-assigned this Dec 18, 2015
@griesemer griesemer added this to the Go1.6 milestone Dec 18, 2015
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Dec 19, 2015

There are two packages name "golang.org/x/net/http2/hpack" -- one in your golang.org/x/net checkout (your copy is old apparently and missing the SetEmitFunc method) and also the copy in stdlib (which is newer).

The test seems to be using a mix of them.

Loading

@extemporalgenome
Copy link
Contributor

@extemporalgenome extemporalgenome commented Dec 19, 2015

Regarding the issue title, should it be "... w/o x/net/http2" ?

Loading

@griesemer griesemer changed the title go/types: std lib tests fail w/o x/tools/net/http2 installed go/types: std lib tests fail w/o x/net/http2 installed Dec 19, 2015
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 7, 2016

CL https://golang.org/cl/18308 mentions this issue.

Loading

@griesemer griesemer closed this in 73c2080 Jan 8, 2016
@golang golang locked and limited conversation to collaborators Jan 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants