Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: don't attempt DNS on .onion addresses #13705

Closed
bradfitz opened this issue Dec 22, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

commented Dec 22, 2015

(Now that .onion addresses are an official TLD)

RFC7686 says:

Applications (including proxies) that implement the Tor protocol MUST recognize .onion names as special by either accessing them directly or using a proxy (e.g., SOCKS [RFC1928]) to do so. Applications that do not implement the Tor protocol SHOULD generate an error upon the use of .onion and SHOULD NOT perform a DNS lookup.

See https://lists.w3.org/Archives/Public/ietf-http-wg/2015OctDec/0222.html and

https://bugzilla.mozilla.org/show_bug.cgi?id=1228457
https://code.google.com/p/chromium/issues/detail?id=562265
curl/curl#543

@bradfitz bradfitz added this to the Unplanned milestone Dec 22, 2015

@mikioh

This comment has been minimized.

Copy link
Contributor

commented Dec 22, 2015

And ".local." too, as per RFC 6762.

The discussion goes on at IAB/IESG like https://tools.ietf.org/html/draft-adpkja-dnsop-special-names-problem and https://www.icann.org/en/system/files/files/name-collision-mitigation-final-28oct15-en.pdf. Hope the consensus will be landed safely.

@bradfitz bradfitz self-assigned this Mar 31, 2016

@bradfitz bradfitz modified the milestones: Go1.7, Unplanned Mar 31, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Mar 31, 2016

CL https://golang.org/cl/21328 mentions this issue.

@gopherbot gopherbot closed this in 72c1180 Apr 2, 2016

@golang golang locked and limited conversation to collaborators Apr 2, 2017

githorray referenced this issue in lightningnetwork/lnd Jun 27, 2018

Merge pull request #1262 from guggero/unix-sockets
rpc: add support for unix sockets
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.