Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: Rename does not overwrite existing files on Plan 9 #13844

Closed
rsc opened this issue Jan 6, 2016 · 4 comments
Closed

os: Rename does not overwrite existing files on Plan 9 #13844

rsc opened this issue Jan 6, 2016 · 4 comments
Assignees
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Jan 6, 2016

TestRenameOverwriteDest should not need an exception for Plan 9.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jan 6, 2016

/cc @0intro

@0intro
Copy link
Member

@0intro 0intro commented Jan 6, 2016

This restriction is not the only difference between Plan 9 and other
operating systems in the os.Rename function.

For example, on Plan 9 you can only rename a file located
in the same directory.

Should we change os.Rename to handle both of these cases like other operating systems?

Renaming a file to a different directory could be done by copying the
file and removing the source file. However, if the source file is a directory,
the situation would be a bit more complex.

@rsc
Copy link
Contributor Author

@rsc rsc commented Jan 6, 2016

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 6, 2016

CL https://golang.org/cl/18291 mentions this issue.

@0intro 0intro self-assigned this Jan 7, 2016
@0intro 0intro closed this in 161f2e8 Jan 8, 2016
@golang golang locked and limited conversation to collaborators Jan 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.