Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: tool should nuke temporary directories when done #13863

Closed
dsnet opened this issue Jan 7, 2016 · 3 comments
Closed

cmd/pprof: tool should nuke temporary directories when done #13863

dsnet opened this issue Jan 7, 2016 · 3 comments
Assignees
Milestone

Comments

@dsnet
Copy link
Member

@dsnet dsnet commented Jan 7, 2016

Using go1.5

Calling web on go tool pprof creates a temporary directory, but forgets to clean it up.

Currently, I see:

rawr@carbonite: /tmp $ ll pprof-*
pprof-258052144:
total 0

pprof-316027049:
total 0

pprof-394800818:
total 0

pprof-675261706:
total 0

pprof-871857163:
total 0

...

I expect to see:

rawr@carbonite: /tmp $ ll pprof-*
ls: cannot access pprof-*: No such file or directory

Probably just a missing defer in cmd/pprof/internal/commands/commands.go.

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 12, 2016

CL https://golang.org/cl/18560 mentions this issue.

@bradfitz bradfitz added this to the Go1.7 milestone Jan 21, 2016
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 11, 2016

@dsnet, please finish the https://go-review.googlesource.com/#/c/18560/ review or fix/close otherwise?

@gopherbot
Copy link

@gopherbot gopherbot commented May 11, 2016

CL https://golang.org/cl/23019 mentions this issue.

@gopherbot gopherbot closed this in e9407ae May 11, 2016
@golang golang locked and limited conversation to collaborators May 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.