Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: UnixListener auto unlinks socket files behavior should be changeable #13877

Closed
absolute8511 opened this issue Jan 8, 2016 · 5 comments

Comments

Projects
None yet
7 participants
@absolute8511
Copy link

commented Jan 8, 2016

The unlink flag should be designed as changeable from outside to avoid auto unlink unix domain socket file. It can be useful while implementing the graceful restart. The graceful restart need the new process listen on the same file and then close the old one. If the old one auto unlink the socket file, it will cause the socket listened by the new process is not available from the client.
The graceful restart can be found here https://github.com/facebookgo/grace

@absolute8511 absolute8511 changed the title net: UnixListener auto unlinks socket files behavious should be changeable net: UnixListener auto unlinks socket files behavior should be changeable Jan 8, 2016

@ianlancetaylor ianlancetaylor added this to the Go1.7 milestone Jan 8, 2016

@danp

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2016

Should this be accomplished by making UnixListener.unlink public?

@absolute8511

This comment has been minimized.

Copy link
Author

commented Apr 18, 2016

Maybe an option for auto unlink and a public method would be great. (just like FD_CLOEXEC)

@bradfitz bradfitz modified the milestones: Go1.7Maybe, Go1.7 Apr 18, 2016

@rsc

This comment has been minimized.

Copy link
Contributor

commented May 17, 2016

Too late for new API.

@rsc rsc modified the milestones: Go1.8, Go1.7Maybe May 17, 2016

@quentinmit quentinmit added the NeedsFix label Oct 7, 2016

@quentinmit

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2016

See also #17131

@gopherbot

This comment has been minimized.

Copy link

commented Oct 27, 2016

CL https://golang.org/cl/32099 mentions this issue.

@gopherbot gopherbot closed this in eb88b3e Oct 28, 2016

@golang golang locked and limited conversation to collaborators Oct 28, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.