Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: don't treat importing of "unsafe" different from other imports #13882

Closed
griesemer opened this issue Jan 8, 2016 · 2 comments
Closed

go/types: don't treat importing of "unsafe" different from other imports #13882

griesemer opened this issue Jan 8, 2016 · 2 comments
Assignees
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Jan 8, 2016

With the change https://go-review.googlesource.com/#/c/18438/ (per issue #13703), package unsafe is now not special anymore and can be installed and imported like any other package.

Only if it is not found elsewhere is the compiler-known package "unsafe" used.

Make the necessary changes to go/types.

(x/tools/go/types always handled unsafe like other packages - the change is only needed for std lib go/types which handles unsafe directly w/o calling the importer to simplify the importer).

@griesemer griesemer self-assigned this Jan 8, 2016
@griesemer griesemer added this to the Go1.6 milestone Jan 8, 2016
@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Jan 8, 2016

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 8, 2016

CL https://golang.org/cl/18445 mentions this issue.

Loading

@griesemer griesemer closed this in 0b3807a Jan 9, 2016
@golang golang locked and limited conversation to collaborators Jan 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants