Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tour: use names instead of numbers for page urls #13917

Open
adg opened this issue Jan 12, 2016 · 2 comments

Comments

@adg
Copy link
Contributor

commented Jan 12, 2016

The current system of using paths like /moretypes/12 is problematic. One is that such URLs are not descriptive. The other is that the numbers change whenever we add or remove a page, breaking existing links. (I have two recent CLs that completely renumber the methods section.)

We should change the URLs to use names instead of numbers. For instance, the URL http://tour.golang.org/methods/4 could be http://tour.golang.org/methods/pointer-receivers instead. This adds a new requirement that all pages within a sub-tour must have a unique name, but I think the existing content meets that requirement already, and I don't think it's an onerous burden for future material.

@campoy - how hard would it be to do this? Looking at the code, I'm not sure how to make the change cleanly.

@adg

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2016

CC @broady

@campoy

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2016

Agreed, having permanent links is worth the hassle of choosing a unique id.

Also, please take into account this extra mapping that we already did from the previous versions to the current one in https://github.com/golang/tour/blob/master/static/js/values.js#L93

@bradfitz bradfitz added this to the Unreleased milestone Jan 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.