Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestSpecialDomainName can hang indefinitely #13939

Closed
mundaym opened this issue Jan 13, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@mundaym
Copy link
Member

commented Jan 13, 2016

The DNS test TestSpecialDomainName can hang indefinitely because it sends a DNS request using UDP and waits for a response without specifying a timeout.

The easiest fix would be to add a timeout to the call to exchange so that the test fails quickly with a nice error message if the request gets lost or is ignored. For example:

msg, err := exchange(server, tt.name, tt.qtype, 3 * time.Second)
@bradfitz

This comment has been minimized.

Copy link
Member

commented Jan 13, 2016

You want to send a change, or do you want us to?

@mundaym

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2016

I'm happy to send a change.

@mundaym

This comment has been minimized.

Copy link
Member Author

commented Jan 14, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Jan 14, 2016

CL https://golang.org/cl/18661 mentions this issue.

@danp

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2016

Ref #13295

Might be nice to not involve the network for these at some point.

@gopherbot gopherbot closed this in c7754c8 Jan 19, 2016

@golang golang locked and limited conversation to collaborators Jan 18, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.