Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upnet: TestSpecialDomainName can hang indefinitely #13939
Comments
This comment has been minimized.
This comment has been minimized.
|
You want to send a change, or do you want us to? |
This comment has been minimized.
This comment has been minimized.
|
I'm happy to send a change. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Jan 14, 2016
|
CL https://golang.org/cl/18661 mentions this issue. |
This comment has been minimized.
This comment has been minimized.
|
Ref #13295 Might be nice to not involve the network for these at some point. |
gopherbot
closed this
in
c7754c8
Jan 19, 2016
golang
locked and limited conversation to collaborators
Jan 18, 2017
gopherbot
added
the
FrozenDueToAge
label
Jan 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
mundaym commentedJan 13, 2016
The DNS test TestSpecialDomainName can hang indefinitely because it sends a DNS request using UDP and waits for a response without specifying a timeout.
The easiest fix would be to add a timeout to the call to exchange so that the test fails quickly with a nice error message if the request gets lost or is ignored. For example: