Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Transport.CloseIdleConnections doesn't close idle http2 connections #13975

Closed
bradfitz opened this issue Jan 15, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@bradfitz
Copy link
Member

commented Jan 15, 2016

The http.Transport is wired up with a hidden http2.Transport by default.

But http.Transport.CloseIdleConnections doesn't call the same method on the hidden http2 transport.

@bradfitz bradfitz self-assigned this Jan 15, 2016

@bradfitz bradfitz added this to the Go1.6 milestone Jan 15, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Jan 15, 2016

CL https://golang.org/cl/18679 mentions this issue.

@gopherbot

This comment has been minimized.

Copy link

commented Jan 15, 2016

CL https://golang.org/cl/18678 mentions this issue.

gopherbot pushed a commit to golang/net that referenced this issue Jan 16, 2016

http2: make configureTransport return the new t2 transport as well
This is needed so another CL in the main repo can keep the pointer
around to pass through Transport.CloseIdleConnections from the http1
transport.

This CL doesn't modify the exported ConfigureTransport
signature. We'll use the private one in the standard library for
now. (since it gets bundled into the same package)

Updates golang/go#13975

Change-Id: I824e9ac4a44616c8c2a480f83bd3dc62bffc30e4
Reviewed-on: https://go-review.googlesource.com/18678
Reviewed-by: Andrew Gerrand <adg@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

@gopherbot gopherbot closed this in 01b8640 Jan 16, 2016

@golang golang locked and limited conversation to collaborators Jan 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.