Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: Transport.CloseIdleConnections doesn't close idle http2 connections #13975
Comments
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/18679 mentions this issue. |
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/18678 mentions this issue. |
gopherbot
pushed a commit
to golang/net
that referenced
this issue
Jan 16, 2016
This is needed so another CL in the main repo can keep the pointer around to pass through Transport.CloseIdleConnections from the http1 transport. This CL doesn't modify the exported ConfigureTransport signature. We'll use the private one in the standard library for now. (since it gets bundled into the same package) Updates golang/go#13975 Change-Id: I824e9ac4a44616c8c2a480f83bd3dc62bffc30e4 Reviewed-on: https://go-review.googlesource.com/18678 Reviewed-by: Andrew Gerrand <adg@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The http.Transport is wired up with a hidden http2.Transport by default.
But http.Transport.CloseIdleConnections doesn't call the same method on the hidden http2 transport.