Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text/template: always return nil for (next Node) #13993

Closed
tnclong opened this issue Jan 18, 2016 · 3 comments
Closed

text/template: always return nil for (next Node) #13993

tnclong opened this issue Jan 18, 2016 · 3 comments
Milestone

Comments

@tnclong
Copy link
Contributor

@tnclong tnclong commented Jan 18, 2016

src/text/template/parse/parse.go:280:func (t *Tree) parse() (next Node)

The return value may don't necessary now.
Would mind any guy to have a check?

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Jan 18, 2016

Yes, looks like the return value has not been needed since https://golang.org/cl/5393049 .

@ianlancetaylor ianlancetaylor added this to the Go1.7 milestone Jan 18, 2016
@dominichamon
Copy link

@dominichamon dominichamon commented Feb 2, 2016

i'd like to take this (for a gentle introduction to making changes to golang).

@rsc rsc modified the milestones: Go1.8, Go1.7 May 18, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 17, 2016

CL https://golang.org/cl/27240 mentions this issue.

@gopherbot gopherbot closed this in c3f05d9 Aug 17, 2016
@golang golang locked and limited conversation to collaborators Aug 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.