Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/race: tests fail #14011

Closed
mwhudson opened this issue Jan 19, 2016 · 3 comments
Closed

runtime/race: tests fail #14011

mwhudson opened this issue Jan 19, 2016 · 3 comments

Comments

@mwhudson
Copy link
Contributor

go test runtime/race fails:

mwhudson@aeglos:deb$ go test -race runtime/race
--- FAIL: TestRace (14.54s)
    race_test.go:45: Failed to run tests: exit status 2
        # command-line-arguments_test
        testdata/issue12225_test.go:11: undefined: unsafe in unsafe.Pointer
        testdata/issue12225_test.go:11: undefined: convert
        testdata/issue12225_test.go:12: undefined: unsafe in unsafe.Pointer
        FAIL    command-line-arguments [build failed]
FAIL
FAIL    runtime/race    33.116s

These tests are (obviously) not run by go tool dist test. What are they for? Should they be fixed and enabled, deleted, something else?

@minux
Copy link
Member

minux commented Jan 19, 2016 via email

@gopherbot
Copy link

CL https://golang.org/cl/18686 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/18712 mentions this issue.

gopherbot pushed a commit that referenced this issue Jan 20, 2016
so that runtime/race tests are included in the race builder.

Update #14011.

Change-Id: I04ac6e47366fdb1fe84ba89da556c6d38f7d4a47
Reviewed-on: https://go-review.googlesource.com/18686
Run-TryBot: Minux Ma <minux@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Jan 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants