Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/pprof: add readline support #14041
changed the title from
Feature request: add readline support for `go tool pprof` interactive mode
cmd/pprof: add readline support
Jan 20, 2016
The upstream pprof maintainer @aalexand proposed to utilize the golang.org/x/crypto/ssh/terminal package for readline functionality.
cl/112436 implements the feature requested here. I was ok'd about vendoring x/crypto/ssh/terminal but found it depends on some packages in x/sys as well. They bring in a lot more files than I hoped and I am currently fighting for all kinds of build/vet errors discovered while vendoring. Already 1.11 dev tree is closed and I am afraid it's too late.