Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: make Transport.CancelRequest somehow work against http2 #14095

Closed
bradfitz opened this issue Jan 26, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@bradfitz
Copy link
Member

commented Jan 26, 2016

https://golang.org/cl/18873 documented loudly that CancelRequest doesn't work against HTTP/2 servers, but perhaps we can make it work anyway.

More background: #13540 ("x/net/http2: decide what to do about Transport.CancelRequest"), which made http.Client stop using CancelRequest itself.

Really, people should just stop using CancelRequest. But in many cases we created the Request, so we could also own the cancel channel and use it.

@bradfitz bradfitz self-assigned this Jan 26, 2016

@bradfitz bradfitz added this to the Go1.7 milestone Jan 26, 2016

@bradfitz bradfitz removed this from the Go1.7 milestone May 10, 2016

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented May 10, 2016

If we lived with this in Go 1.6, we can live with it in Go 1.7 and beyond. CancelRequest should just remain deprecated.

@bradfitz bradfitz closed this May 10, 2016

@golang golang locked and limited conversation to collaborators May 10, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.