Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/link: serialize Reloc.Variant field to Go object files #14218
In RISC architectures, address relocations usually need to
For example, Power load/store instructions have two forms,
Currently, we have two separate relocations in
We already have a
The proposal is to serialize the
The benefit is that: the variants are defined in arch-specific
Adds a new R_PCRELDBL relocation for 2-byte aligned relative relocations on s390x. Should be removed once #14218 is implemented. Change-Id: I79dd2d8e746ba8cbc26c570faccfdd691e8161e8 Reviewed-on: https://go-review.googlesource.com/20941 Reviewed-by: Brad Fitzpatrick <email@example.com> Run-TryBot: Brad Fitzpatrick <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com>
I've sent a basic CL that does this: https://go-review.googlesource.com/#/c/27932/
It increases object file size by about 1.6%. I think it would be possible to reduce the object sizes by reducing the sizes of the types we are using for
I'm not sure what other changes are planned that this could be submitted with/integrated into to minimize disruption from the object file format change.
On 29 August 2016 at 03:20, Michael Munday firstname.lastname@example.org wrote:
You should update cmd/internal/goobj though.
I have a CL that needs some updates to improve its efficiency and demonstrate its value better. I'll try and allocate it some time this week.
The change is very minor and would be fully reversible in future versions (Go makes no guarantees about object file format that I know of), so I don't know if it counts as a 'proposal'.