Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/shiny/example/basic: alpha channel is ignored on windows #14220

Closed
alexbrainman opened this issue Feb 4, 2016 · 5 comments
Closed

x/exp/shiny/example/basic: alpha channel is ignored on windows #14220

alexbrainman opened this issue Feb 4, 2016 · 5 comments

Comments

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Feb 4, 2016

The x/exp/shiny/example/basic looks like
is
but should look like
expected

Alex

@nigeltao
Copy link
Contributor

@nigeltao nigeltao commented Feb 4, 2016

The Upload method shouldn't blend. Only those methods which take a draw.Op arg (Fill, Draw, Copy Scale) should blend. (Upload could possibly also take a draw.Op arg, and then blend, but I think that that is a separate issue).

I think the top image is actually working as intended, although IIRC the windriver doesn't do textures yet. In particular, the top image matches what I see on x11driver and gldriver/linux.

@nigeltao nigeltao closed this Feb 4, 2016
@nigeltao
Copy link
Contributor

@nigeltao nigeltao commented Feb 4, 2016

https://go.googlesource.com/exp/+/master/shiny/screen/screen.go#202 says that "The destination's contents are overwritten; the draw operator is implicitly draw.Src."

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 4, 2016

CL https://golang.org/cl/19213 mentions this issue.

@alexbrainman
Copy link
Member Author

@alexbrainman alexbrainman commented Feb 5, 2016

what I see on x11driver and gldriver/linux

Please post picture of your x/exp/shiny/example/basic window on linux, so I can see what else needs to be done for windows. Thank you.

Alex

@nigeltao
Copy link
Contributor

@nigeltao nigeltao commented Feb 5, 2016

Screenshot of the top-left corner of my window:
shiny-basic

@golang golang locked and limited conversation to collaborators Feb 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants