Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: use `go tool dist test -k` on fast builders? #14305
Especially for fast builders, I suggest that we make then use the keepgoing
This will be especially useful if a flaky tests fails and then masks the real
As an example, https://golang.org/cl/19455 changes the runtime, but
I don't know if it's worthwhile to also use the -k for the trybots. I can see
I'm in favor of
I don't think trybots should use
The builders also don't use "go tool dist test" by itself anyway. The builder coordinator has its own logic for test sharding and when to stop.
I'm not sure how useful this would be in practice. Usually the first failure is enough and the rest would be noise.
I also want to read errors quickly from the builders and not waste more time finding more errors (especially if they'll be useless).
But as long as it can be done without slowing things done, I'm not opposed to this.
I don't have the time to work on this at the moment, though.