Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: missing some cipher suite constants #14370

Closed
rutledgechinfeman opened this issue Feb 18, 2016 · 4 comments
Closed

crypto/tls: missing some cipher suite constants #14370

rutledgechinfeman opened this issue Feb 18, 2016 · 4 comments

Comments

@rutledgechinfeman
Copy link

@rutledgechinfeman rutledgechinfeman commented Feb 18, 2016

This file has a list of constants for TLS cipher suites:

https://golang.org/src/crypto/tls/cipher_suites.go

The list is incomplete, for example the ChaCha20-Poly1305 ciphers are missing. It would be useful to either (a) complete the list of ciphers and, or (b) document how the list of ciphers is curated.

If (a), there should also be some mechanism to keep the list up-to-date over time.

@minux

This comment has been minimized.

Copy link
Member

@minux minux commented Feb 21, 2016

@bradfitz bradfitz changed the title package crypto/tls cipher suite list incomplete crypto/tls: missing some cipher suite constants Feb 23, 2016
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Feb 23, 2016

@agl, do you want [somebody else] to document that this is only those supported by the crypto/tls package, or do you want [somebody else] to auto-generate those constants, perhaps with go generate from https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-4 ?

@bradfitz bradfitz added this to the Unplanned milestone Feb 23, 2016
@agl

This comment has been minimized.

Copy link
Contributor

@agl agl commented Mar 10, 2016

I don't think that we should try to include every constant in that package because of the large number of them. I'll send out a change to document this in a sec.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Mar 11, 2016

CL https://golang.org/cl/20551 mentions this issue.

@gopherbot gopherbot closed this in 055dcb7 Mar 12, 2016
@golang golang locked and limited conversation to collaborators Mar 13, 2017
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
Fixes golang#14370.

Change-Id: Ieb95ee3494f592fb5fc74aa4b803479671816927
Reviewed-on: https://go-review.googlesource.com/20551
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
Fixes golang#14370.

Change-Id: Ieb95ee3494f592fb5fc74aa4b803479671816927
Reviewed-on: https://go-review.googlesource.com/20551
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.