Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: TestTransportPersistConnLeak test failure/flake on windows 2003 #14375
Comments
ianlancetaylor
changed the title
failure to build go 1.6 on windows 2003
net/http: failure to build go 1.6 on windows 2003
Feb 18, 2016
ianlancetaylor
added this to the Go1.6.1 milestone
Feb 18, 2016
This comment has been minimized.
This comment has been minimized.
|
Note that you can still use your Go installation, despite this test failure. |
This comment has been minimized.
This comment has been minimized.
|
Hm. I haven't seen that one, or at least not in ages. I wonder what they are. |
bradfitz
self-assigned this
Feb 18, 2016
bradfitz
changed the title
net/http: failure to build go 1.6 on windows 2003
net/http: TestTransportPersistConnLeak test failure/flake on windows 2003
Feb 18, 2016
This comment has been minimized.
This comment has been minimized.
|
transport_test.go line 1022: ALL TESTS PASSED |
This comment has been minimized.
This comment has been minimized.
|
I can reproduce this: Am I seeing some unclosed network connections? Brad let me know, if you want me to try something. Alex |
This comment has been minimized.
This comment has been minimized.
|
That's too hard to read. I only want to see the new goroutines. See the leak check stuff I added in grpc: https://github.com/grpc/grpc-go/blob/master/test/end2end_test.go // interestingGoroutines returns all goroutines we care about for the purpose
// of leak checking. It excludes testing or runtime ones.
func interestingGoroutines() (gs []string) {
buf := make([]byte, 2<<20)
buf = buf[:runtime.Stack(buf, true)]
for _, g := range strings.Split(string(buf), "\n\n") {
sl := strings.SplitN(g, "\n", 2)
if len(sl) != 2 {
continue
}
stack := strings.TrimSpace(sl[1])
if strings.HasPrefix(stack, "testing.RunTests") {
continue
}
if stack == "" ||
strings.Contains(stack, "testing.Main(") ||
strings.Contains(stack, "runtime.goexit") ||
strings.Contains(stack, "created by runtime.gc") ||
strings.Contains(stack, "interestingGoroutines") ||
strings.Contains(stack, "runtime.MHeap_Scavenger") {
continue
}
gs = append(gs, g)
}
sort.Strings(gs)
return
}
// leakCheck snapshots the currently-running goroutines and returns a
// function to be run at the end of tests to see whether any
// goroutines leaked.
func leakCheck(t testing.TB) func() {
orig := map[string]bool{}
for _, g := range interestingGoroutines() {
orig[g] = true
}
return func() {
// Loop, waiting for goroutines to shut down.
// Wait up to 5 seconds, but finish as quickly as possible.
deadline := time.Now().Add(5 * time.Second)
for {
var leaked []string
for _, g := range interestingGoroutines() {
if !orig[g] {
leaked = append(leaked, g)
}
}
if len(leaked) == 0 {
return
}
if time.Now().Before(deadline) {
time.Sleep(50 * time.Millisecond)
continue
}
for _, g := range leaked {
t.Errorf("Leaked goroutine: %v", g)
}
return
}
}
} |
This comment has been minimized.
This comment has been minimized.
|
Sorry for late reply (I lost your reply). I have added leakCheck, but the package already has interestingGoroutines. The TestTransportPersistConnLeak know fails every time - I am sure that is not what you want. Please, let me know what to do. Thank you. Alex |
bradfitz
modified the milestones:
Go1.6.1,
Go1.6.2
Apr 7, 2016
rsc
modified the milestones:
Go1.7,
Go1.6.2
Apr 7, 2016
bradfitz
added
the
Testing
label
May 18, 2016
This comment has been minimized.
This comment has been minimized.
bradfitz
closed this
May 20, 2016
golang
locked and limited conversation to collaborators
May 20, 2017
gopherbot
added
the
FrozenDueToAge
label
May 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
litg commentedFeb 18, 2016
ok net 23.938s
--- FAIL: TestTransportPersistConnLeak (0.17s)
transport_test.go:1032: goroutine growth: 24 -> 121 -> 36 (delta: 12)
transport_test.go:1033: too many new goroutines
FAIL
FAIL net/http 19.625s
ok net/http/cgi 2.000s