Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/unix: zero-sized field may be removed by go1.5's change. #14440

Open
hirochachacha opened this issue Feb 21, 2016 · 3 comments
Open

x/sys/unix: zero-sized field may be removed by go1.5's change. #14440

hirochachacha opened this issue Feb 21, 2016 · 3 comments
Milestone

Comments

@hirochachacha
Copy link
Contributor

@hirochachacha hirochachacha commented Feb 21, 2016

Currently source code seems to be generated by go <= 1.4.

https://godoc.org/golang.org/x/sys/unix#InotifyEvent

Because of go 1.5's change, we may want to remove zero-size field.

https://golang.org/doc/go1.5#cgo

I don't know this is intentional. If not we need to updated code.
I also want to know which OS version are targeted for x/sys/unix.
Clarifying it somewhere is reasonable for me.

Thank you.

@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Feb 21, 2016
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Feb 21, 2016

Thanks for the bug report.

There is no clear documentation for which operating system versions are supported by x/sys/unix. That would be desirable, but it seems an unrelated issue. Note that the set of supported versions is distinct from the question of which version is used to generate the files.

@hirochachacha
Copy link
Contributor Author

@hirochachacha hirochachacha commented Feb 22, 2016

it seems an unrelated issue.

Indeed.

Honestly, I want to post more general question to golang-dev:
"which version of OS and Go is preferable for code generation?"
I tried to post it, but it failed silently. So I filed a relevant issue instead. Sorry for that.

@hirochachacha
Copy link
Contributor Author

@hirochachacha hirochachacha commented Feb 22, 2016

Oops. It seems to that google group has delayed. sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants