Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cgo: tsan hooks broke linux-amd64-sid builder #14559

Closed
bradfitz opened this issue Feb 29, 2016 · 4 comments

Comments

@bradfitz
Copy link
Member

bradfitz commented Feb 29, 2016

@josharian notes that https://go-review.googlesource.com/17421 broke the linux-amd64-sid builder:

e.g.
http://build.golang.org/log/cd17e7f7d6e331b31d626105c6abbab6753eccf8

##### ../misc/cgo/testsanitizers
skipping msan tests: -fsanitize=memory not supported
FAIL: tsan
FAIL: tsan2
2016/02/28 05:10:58 Failed: exit status 1
2016/02/28 05:10:58 FAILED
@bradfitz bradfitz added this to the Go1.7 milestone Feb 29, 2016
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 29, 2016

CL https://golang.org/cl/20050 mentions this issue.

gopherbot pushed a commit that referenced this issue Feb 29, 2016
Update #14559.

Change-Id: I8894f8e16902685f55a21d902199fbe0905f0558
Reviewed-on: https://go-review.googlesource.com/20050
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
@siebenmann

This comment has been minimized.

Copy link

siebenmann commented Feb 29, 2016

This is also broken on x86 Fedora (22 and 23) at the moment. The latest git tip (with the report stderr commit) reports:

##### ../misc/cgo/testsanitizers
skipping msan tests: clang version 3.7 (older than 3.8) incompatible with linux version 4.3 (4.1 or newer)
# command-line-arguments
/usr/bin/ld: cannot find /usr/bin/../lib/clang/3.7.0/lib/linux/libclang_rt.tsan-x86_64.a: No such file or directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)
FAIL: tsan
# command-line-arguments
/usr/bin/ld: cannot find /usr/bin/../lib/clang/3.7.0/lib/linux/libclang_rt.tsan-x86_64.a: No such file or directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)
FAIL: tsan2
2016/02/29 10:55:40 Failed: exit status 1

As far as I can tell, Fedora doesn't build or package libclang_rt.tsan-x86_64.a. It does package gcc versions (as libtsan/libtsan-static), which I didn't have installed until I went looking for them; installing them made no difference in the error here.

gopherbot pushed a commit that referenced this issue Feb 29, 2016
Update #14559.

Change-Id: I92603602e5d0a5fcae43f3084f234ff606447190
Reviewed-on: https://go-review.googlesource.com/20056
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@siebenmann

This comment has been minimized.

Copy link

siebenmann commented Mar 1, 2016

For what it's worth, commit eaf5235 (fixing #14570) fixes my issue on Fedora 22/23, as its check for clang < 3.8 on kernel >= 4.1 now skips tsan tests too.

(Also, that commit's 'does -fsanitize=thread work' check would presumably also protect Fedora 22/23 against this issue.)

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

ianlancetaylor commented Mar 1, 2016

This is working now.

@golang golang locked and limited conversation to collaborators Mar 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.