Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: make sure copylock knows sync.Cond cannot be copied #14582

Closed
rsc opened this issue Mar 1, 2016 · 2 comments
Closed

cmd/vet: make sure copylock knows sync.Cond cannot be copied #14582

rsc opened this issue Mar 1, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.7

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Mar 1, 2016

As a followup to #8005, make sure that vet understands that sync.Cond cannot be copied. The Locker in that struct does not suffice because it's an interface value, not an embedded struct, so it's a pointer to a lock, which is in general fine to copy.
@rsc rsc added this to the Go1.7 milestone Mar 1, 2016
@rsc rsc mentioned this issue Mar 1, 2016
Closed
@valyala
Copy link
Contributor

@valyala valyala commented Apr 14, 2016

I'll look into this on the next week
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 14, 2016

CL https://golang.org/cl/22015 mentions this issue.
@gopherbot gopherbot closed this in c81a353 May 6, 2016
@golang golang locked and limited conversation to collaborators May 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.7
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@rsc @valyala @gopherbot
You can’t perform that action at this time.