New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: SSA, don't re-copy spilled output parameters #14586

Open
randall77 opened this Issue Mar 1, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@randall77
Contributor

randall77 commented Mar 1, 2016

func f(a []int) (s int) {
    for _, x := range a {
        s += x
    }
    runtime.GC()
    return
}

The SSA-generated code does this after runtime.GC():

        MOVQ    "".s+32(FP), BX
        MOVQ    BX, "".s+32(FP)

We should teach the compiler that it doesn't need to move the result to the output slot if was already spilled to the correct slot.

@bradfitz bradfitz modified the milestone: Unplanned Apr 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment