Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/ast: CommentMap should try to update comment positions #14629

Open
griesemer opened this Issue Mar 3, 2016 · 2 comments

Comments

Projects
None yet
5 participants
@griesemer
Copy link
Contributor

griesemer commented Mar 3, 2016

When updating nodes in a comment map, comments after that node may have position information that leads to wrong placement. Try to update position information if possible.

@griesemer griesemer self-assigned this Mar 3, 2016

@bradfitz bradfitz added this to the Go1.7 milestone Apr 10, 2016

@griesemer

This comment has been minimized.

Copy link
Contributor Author

griesemer commented May 9, 2016

Has been like this for a while. Leaving for 1.8.

@griesemer griesemer modified the milestones: Go1.8, Go1.7 May 9, 2016

@griesemer griesemer modified the milestones: Go1.8Maybe, Go1.8 Oct 5, 2016

@quentinmit quentinmit added the NeedsFix label Oct 10, 2016

@rsc rsc modified the milestones: Go1.9, Go1.8Maybe Oct 20, 2016

@griesemer griesemer modified the milestones: Go1.9Maybe, Go1.9 Jun 6, 2017

@griesemer

This comment has been minimized.

Copy link
Contributor Author

griesemer commented Jun 20, 2017

To late again. Moving to 1.10.

@griesemer griesemer modified the milestones: Go1.10, Go1.9Maybe Jun 20, 2017

@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Unplanned Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.