Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: oidSignatureDSAWithSHA256 has incorrect value #14663

Closed
AGWA opened this issue Mar 5, 2016 · 2 comments
Closed

crypto/x509: oidSignatureDSAWithSHA256 has incorrect value #14663

AGWA opened this issue Mar 5, 2016 · 2 comments
Assignees

Comments

@AGWA
Copy link

@AGWA AGWA commented Mar 5, 2016

The value of oidSignatureDSAWithSHA256 is currently defined as:

oidSignatureDSAWithSHA256 = asn1.ObjectIdentifier{2, 16, 840, 1, 101, 4, 3, 2}

It should be:

oidSignatureDSAWithSHA256 = asn1.ObjectIdentifier{2, 16, 840, 1, 101, 3, 4, 3, 2}

per https://tools.ietf.org/html/rfc5758#section-3.1:

 id-dsa-with-sha256 OBJECT IDENTIFIER  ::=  { joint-iso-ccitt(2)
     country(16) us(840) organization(1) gov(101) csor(3)
     algorithms(4) id-dsa-with-sha2(3) 2 }.
@AGWA
Copy link
Author

@AGWA AGWA commented Mar 5, 2016

This OID is also defined incorrectly in the x/crypto/ocsp package.

@agl agl self-assigned this Mar 10, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 11, 2016

CL https://golang.org/cl/20549 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 12, 2016
I copied this down incorrectly. See
https://tools.ietf.org/html/rfc5758#section-3.1.

Thankfully it's incredibly obscure.

Fixes #14663.

Change-Id: I4792ee979916cc15aa2e300c8bc989bc4f9c63ac
Reviewed-on: https://go-review.googlesource.com/20549
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Adam Langley <agl@golang.org>
@golang golang locked and limited conversation to collaborators Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.