Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDialerDualStackFDLeak i/o timeout #14717

Closed
bradfitz opened this issue Mar 8, 2016 · 6 comments

Comments

Projects
None yet
5 participants
@bradfitz
Copy link
Member

commented Mar 8, 2016

TestDialerDualStackFDLeak is still flaky, at least on openbsd.

I see these often: (@aclements, stats?)

https://storage.googleapis.com/go-build-log/e649481c/openbsd-386-gce58_73f861b3.log

...
ok      mime/multipart  1.551s
ok      mime/quotedprintable    1.366s
--- FAIL: TestDialerDualStackFDLeak (0.12s)
    dial_test.go:213: dial tcp 127.0.0.1:19773: i/o timeout
FAIL
FAIL    net 8.870s
...

(Related previous deflaking effort for this func was in #14223, but that was apparently not about i/o timeouts)

@mikioh, can you deflake? And if not, can we just disable that test on OpenBSD? Flaky tests do more harm than good.

@bradfitz bradfitz added the OS-OpenBSD label Mar 8, 2016

@bradfitz bradfitz added this to the Go1.7 milestone Mar 8, 2016

@aclements

This comment has been minimized.

@bradfitz bradfitz changed the title net: TestDialerDualStackFDLeak i/o timeout on OpenBSD net: TestDialerDualStackFDLeak i/o timeout Mar 8, 2016

@bradfitz bradfitz removed the OS-OpenBSD label Mar 8, 2016

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2016

Thanks. Removed OpenBSD-specific stuff from this bug.

@mikioh

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2016

I guess this is a sign that indicates that the current Dialer{DualStack: true} has some potential flaw, especially on the platforms which never allow IP dual stack sockets using IPv6 IPv4-mapped addresses. Will investigate after fixing #11837 and #13360.

@mdempsky

This comment has been minimized.

Copy link
Member

commented Apr 12, 2016

Related: #13324 and #15157.

@mikioh mikioh removed their assignment May 6, 2016

@mikioh mikioh added the Testing label May 11, 2016

@mikioh mikioh modified the milestones: Go1.7Maybe, Go1.7 May 19, 2016

@mikioh

This comment has been minimized.

Copy link
Contributor

commented May 19, 2016

Maybe relaxing max wait duration mitigate TestDialerDualStackFDLeak.

@gopherbot

This comment has been minimized.

Copy link

commented May 19, 2016

CL https://golang.org/cl/23244 mentions this issue.

@gopherbot gopherbot closed this in 086d7b0 May 19, 2016

@golang golang locked and limited conversation to collaborators May 19, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.