Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDialerFallbackDelay fails when no external IPv6 connectivity #14731

Closed
mikioh opened this issue Mar 9, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@mikioh
Copy link
Contributor

commented Mar 9, 2016

For example,

go test -v -run=TestDialerFallbackDelay
--- FAIL: TestDialerFallbackDelay (0.00s)
    dial_test.go:477: #1: got 378.549µs; want >= 199ms
    dial_test.go:477: #2: got 440.764µs; want >= 299ms
FAIL

Looks like it requires -ipv6 flag.

@mikioh mikioh added this to the Go1.7 milestone Mar 9, 2016

@pmarks-net

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2016

I see the problem. slowDialTCP interprets a zero deadline as "don't wait", rather than "wait forever".

You can reproduce the bug on a dual-stack Linux machine by running:

$ sudo ip -6 route add unreachable 2001:2::254
$ ../bin/go test -v net -run TestDialerFallbackDelay
@gopherbot

This comment has been minimized.

Copy link

commented Mar 9, 2016

CL https://golang.org/cl/20493 mentions this issue.

@gopherbot gopherbot closed this in 92dfc12 Mar 10, 2016

@golang golang locked and limited conversation to collaborators Mar 13, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.