cmd/dist: missing zversion.go when building for windows on mac

[dcboy]

Please answer these questions before submitting your issue. Thanks!

1. What version of Go are you using (go version)?
   go version go1.6 darwin/amd64
2. What operating system and processor architecture are you using (go env)?
   ➜ src git:(master) go env
   GOARCH="amd64"
   GOBIN=""
   GOEXE=""
   GOHOSTARCH="amd64"
   GOHOSTOS="darwin"
   GOOS="darwin"
   GOPATH="/Volumes/D/go"
   GORACE=""
   GOROOT="/usr/local/go"
   GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
   GO15VENDOREXPERIMENT="1"
   CC="clang"
   GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fno-common"
   CXX="clang++"
   CGO_ENABLED="1"
3. What did you do?
   cd $GOROOT/src
   GOOS=windows GOARCH=386 PATH=$PATH ./make.bash
4. What did you expect to see?

Building Go bootstrap tool.

cmd/dist
go: open /usr/local/go/src/runtime/internal/sys/zversion.go: no such file or directory

[ianlancetaylor]

Note that it is not necessary to run make.bash again for a cross-compiler. Once you've run make.bash for darwin/amd64, you can build for Windows by running

GOOS=windows GOARCH=386 go install PROGRAM

[minux]

crosscompiling doesn't need to run make.bash anymore. Just GOOS=windows GOARCH=386 go install std and GOOS=windows GOARCH=386 go build somePackage

[davecheney]

@minux @ianlancetaylor I think we should stop shipping the make.bash and other scripts as part of the binary distributions. They cannot be used safely.

[bradfitz]

/cc @adg

[adg]

@davecheney they can't?

[davecheney]

@adg in an ideal world, maybe those scripts would work, but when the files
are owned by root, they are a temptation to reach for the sudo hammer and
that'll just make things worse.

You don't need to run ./make.bash to season a Go install for cross
compilation, so I think we should remove the scripts to prevent the
temptation to follow the outdated tutorials on the internet.

On Wed, Mar 30, 2016 at 9:40 AM, Andrew Gerrand notifications@github.com
wrote:

@davecheney https://github.com/davecheney they can't?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#15018 (comment)

[adg]

@davecheney I didn't think about root. The scripts do work for people that install the binary tarball or zip under their own usernames.

Maybe we should just remove make/all.bash/bat for the MSI and PKG installers?

[davecheney]

@davecheney I didn't think about root. The scripts do work for people that install the binary tarball or zip under their own usernames.

I don't think this is the case. Our installation instructions tell people to place the contents in /usr/local/go and not owned by their own username.

We strongly discourage people from placing the contents elsewhere as that raises the spectre of GOROOT.

I agree that these scripts should be stripped from the MSI and PKG installers. I think they should also be stripped from the zip and tar distributions.

If people want to install from source, they should check it out from git or use the source tarball. All the rest of the mechanisms should not be useable as proxies for the source tarball.

[adg]

Our installation instructions tell people to place the contents in /usr/local/go and not owned by their own username.

We strongly discourage people from placing the contents elsewhere as that raises the spectre of GOROOT.

See the Getting Started docs, where we helpfully explain how to install Go elsewhere. We don't mention permissions at all.

I agree that these scripts should be stripped from the MSI and PKG installers. I think they should also be stripped from the zip and tar distributions.

Seems reasonable. Should be a trivial change to x/build/cmd/release.

[minux]

we still don't understand the problem here, so we shouldn't hurry to blame make.bash. zversion.go should exist, and if it's really owned by root, how could make.bash somehow make it disappear?

[davecheney]

@minux, yes. Sorry I distracted the issue by talking about strategies to
talk about overcoming the outdated information on the internet on how to
prepare your Go installation for cross compilation, which are now
unnecessary.

On Wed, Mar 30, 2016 at 10:34 AM, Minux Ma notifications@github.com wrote:

we still don't understand the problem here, so we shouldn't hurry
to blame make.bash.

zversion.go should exist, and if it's really owned by root, how could
make.bash somehow make it disappear?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#15018 (comment)

[bradfitz]

@dcboy, sure you don't have Go 1.4 or Go 1.5 in /usr/local/go?

What does /usr/local/go/bin/go version say?