Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: silent test failures #15109

Closed
aclements opened this issue Apr 4, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@aclements
Copy link
Member

commented Apr 4, 2016

The net test has been failing silently every few dozen commits on the darwin-* and dragonfly-amd64 builders:
2016-04-03T06:22:07-7c15b2a/dragonfly-amd64
2016-04-03T06:22:07-7c15b2a/darwin-386-10_10
[2016-04-02T02:08:59-6a0bb87/dragonfly-amd64](https://build.golang.org/log/f6860
622974eaf79d09f452a597a1bdfeed9894c)
2016-04-01T22:23:13-59fc42b/dragonfly-amd64
2016-03-31T23:18:24-ec5083e/dragonfly-amd64
[2016-03-31T20:42:02-f5bd355/darwin-amd64-10_10](https://build.golang.org/log/08
fcfca2e6b1380ce88ae03d9f87fa8578e2fb34)
[2016-03-31T06:12:36-a6557a0/dragonfly-amd64](https://build.golang.org/log/0d276
43415c8513a2391f699cb164b285e96e9d1)
[2016-03-30T22:31:07-3efefd9/darwin-amd64-10_10](https://build.golang.org/log/81
f1d8b39f9e849d58dc7c411eb43a75499e0451)
[2016-03-30T22:27:13-d8f1f8d/dragonfly-amd64](https://build.golang.org/log/018ec
8ab2953bd52d9820569072d6d17ebefd3a2)

It also just failed on a trybot: https://storage.googleapis.com/go-build-log/da2905f1/darwin-amd64-10_10_ebfff129.log

@bradfitz bradfitz added the Builders label Apr 4, 2016

@bradfitz bradfitz added this to the Unreleased milestone Apr 7, 2016

@mikioh

This comment has been minimized.

Copy link
Contributor

commented May 11, 2016

#15654 is an interesting issue. It suggests that the current testing package is able to be a root cause of silent errors mentioned above. We probably need to revisit the use of tester goroutines and defer blocks in test cases.

@bradfitz

This comment has been minimized.

Copy link
Member

commented May 12, 2016

@mikioh, interesting indeed. Good connection!

@mikioh mikioh modified the milestones: Go1.7Maybe, Unreleased May 19, 2016

@mikioh

This comment has been minimized.

Copy link
Contributor

commented May 19, 2016

Waiting for the fix of #15654.

@bradfitz bradfitz assigned mpvl and unassigned bradfitz May 20, 2016

@mikioh mikioh unassigned mpvl Jun 3, 2016

@mikioh

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2016

The fix for #15654 unveils the root cause of silent failures.

panic: Fail in goroutine after TestAcceptTimeout has completed

goroutine 906 [running]:
panic(0x615920, 0xc4204921e0)
    /tmp/gobuilder/dragonfly-amd64-42c51debe824/go/src/runtime/panic.go:500 +0x1a1
testing.(*common).Fail(0xc42015a840)
    /tmp/gobuilder/dragonfly-amd64-42c51debe824/go/src/testing/testing.go:412 +0x11f
testing.(*common).Error(0xc42015a840, 0xc42003ff78, 0x1, 0x1)
    /tmp/gobuilder/dragonfly-amd64-42c51debe824/go/src/testing/testing.go:478 +0x6f
net.TestAcceptTimeout.func1(0x7626c0, 0xc420156420, 0xc42015a840)
    /tmp/gobuilder/dragonfly-amd64-42c51debe824/go/src/net/timeout_test.go:172 +0x143
created by net.TestAcceptTimeout
    /tmp/gobuilder/dragonfly-amd64-42c51debe824/go/src/net/timeout_test.go:178 +0x856
FAIL    net 1.573s

A leaked test helper goroutine.

@gopherbot

This comment has been minimized.

Copy link

commented Jun 3, 2016

CL https://golang.org/cl/23742 mentions this issue.

@gopherbot gopherbot closed this in c3bd93a Jun 3, 2016

@golang golang locked and limited conversation to collaborators Jun 3, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.