Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: TestTRun failing on the plan9/arm builder since CL 21504 #15149

Closed
0intro opened this issue Apr 6, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@0intro
Copy link
Member

commented Apr 6, 2016

Since CL 21504, TestTRun is failing on the plan9/arm builder.

--- FAIL: TestTRun (0.06s)
    sub_test.go:373: failnow skips future sequential and parallel tests at same level:ouput:
        got:
        --- FAIL: failnow skips future sequential and parallel tests at same level (0.01s)
            --- FAIL: failnow skips future sequential and parallel tests at same level/#00 (0.00s)
        want:
        --- FAIL: failnow skips future sequential and parallel tests at same level (0.00s)
            --- FAIL: failnow skips future sequential and parallel tests at same level/#00 (0.00s)
FAIL
FAIL    testing 3.440s

See http://build.golang.org/log/41d221b5accf16216bb6d9f1a767cbfff7c8e6f1

The plan9/arm builder is running on a Raspberry Pi 3, which is a slow machine. The output comparison is failing because the test executes slightly slower than expected.

Perhaps we should ignore the time when comparing the string. What do you think?

CC: @mpvl @bradfitz @millerresearch

@0intro 0intro added this to the Go1.7 milestone Apr 6, 2016

@millerresearch

This comment has been minimized.

Copy link

commented Apr 6, 2016

Perhaps we should ignore the time when comparing the string. What do you think?

Yes, either sanitizeLog could remove the duration (N.NNs) from the end of lines, or the comparison between want: and got: could be done as a regular expression match (and sanitizeLog would not be needed).

@mpvl mpvl self-assigned this Apr 6, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Apr 6, 2016

CL https://golang.org/cl/21602 mentions this issue.

@gopherbot gopherbot closed this in 5176a4b Apr 6, 2016

@golang golang locked and limited conversation to collaborators Apr 6, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.