Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: remove dependencies on cmd/internal/obj #15165

Closed
mdempsky opened this issue Apr 7, 2016 · 3 comments

Comments

Projects
None yet
5 participants
@mdempsky
Copy link
Member

commented Apr 7, 2016

cmd/internal/obj is for writing Go object files, whereas cmd/link only reads Go object files. We should remove cmd/link's dependencies on cmd/internal/obj by moving legitimately shared constants/types into separate packages.

See also #14782.

@davecheney

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2016

Yes please.

On Thu, Apr 7, 2016 at 3:09 PM, Matthew Dempsky notifications@github.com
wrote:

cmd/internal/obj is for writing Go object files, whereas cmd/link only
reads Go object files. We should remove cmd/link's dependencies on
cmd/internal/obj by moving legitimately shared constants/types into
separate packages.

See also #14782 #14782.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#15165

@mwhudson

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2016

Concur. I even wonder about de-coupling the constants used for LSym.Type between cmd/internal/obj and the linker -- the latter uses far more. The code to read them from object files could map from the obj.Type to the ld.Type. Or something -- currently the constant definitions in obj "know" way too much about the guts of the linker. (It doesn't help that the linker depends on the order these constants sort in)

@gopherbot

This comment has been minimized.

Copy link

commented Apr 7, 2016

CL https://golang.org/cl/21644 mentions this issue.

mk0x9 pushed a commit to mk0x9/go that referenced this issue Apr 7, 2016

cmd: extract obj's Biobuf code into new bio package
API could still be made more Go-ey.

Updates golang#15165.

Change-Id: I514ffceffa43c293ae5d7e5f1e9193fda0098865
Reviewed-on: https://go-review.googlesource.com/21644
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

@bradfitz bradfitz added this to the Unplanned milestone Apr 7, 2016

@gopherbot gopherbot closed this in 1e3570a Apr 19, 2017

@golang golang locked and limited conversation to collaborators Apr 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.