cmd/link: remove dependencies on cmd/internal/obj #15165
Comments
Yes please. On Thu, Apr 7, 2016 at 3:09 PM, Matthew Dempsky notifications@github.com
|
Concur. I even wonder about de-coupling the constants used for LSym.Type between cmd/internal/obj and the linker -- the latter uses far more. The code to read them from object files could map from the obj.Type to the ld.Type. Or something -- currently the constant definitions in obj "know" way too much about the guts of the linker. (It doesn't help that the linker depends on the order these constants sort in) |
CL https://golang.org/cl/21644 mentions this issue. |
API could still be made more Go-ey. Updates golang#15165. Change-Id: I514ffceffa43c293ae5d7e5f1e9193fda0098865 Reviewed-on: https://go-review.googlesource.com/21644 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
cmd/internal/obj is for writing Go object files, whereas cmd/link only reads Go object files. We should remove cmd/link's dependencies on cmd/internal/obj by moving legitimately shared constants/types into separate packages.
See also #14782.
The text was updated successfully, but these errors were encountered: