Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: 'go vet' warnings #15177

Closed
valyala opened this issue Apr 7, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@valyala
Copy link
Contributor

commented Apr 7, 2016

go vet in tip reports the following warnings. IMHO, they should be fixed. @bradfitz ?

$ go vet net/http/...
net/http/h2_bundle.go:5013: assignment copies lock value to *cfg: crypto/tls.Config contains sync.Once contains sync.Mutex
net/http/transfer.go:215: net/http/internal.FlushAfterChunkWriter composite literal uses unkeyed fields
exit status 1
net/http/client_test.go:314: missing argument for Fatalf("%T"): format reads arg 1, have only 0 args
net/http/transport_test.go:118: arg c for printf verb %p of wrong type: net.Conn
exit status 1
net/http/httptest/server.go:119: assignment copies lock value to *s.TLS: crypto/tls.Config contains sync.Once contains sync.Mutex
net/http/httptest/server.go:198: arg c for printf verb %p of wrong type: net.Conn
net/http/httptest/httptest_test.go:158: unrecognized printf verb 'i'
net/http/httptest/httptest_test.go:161: unrecognized printf verb 'i'
exit status 1
net/http/httputil/dump_test.go:218: arg body for printf verb %p of wrong type: io.Reader
exit status 1
@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 7, 2016

Some, but not all.

@bradfitz bradfitz added the Suggested label Apr 7, 2016

@bradfitz bradfitz added this to the Unplanned milestone Apr 7, 2016

@gopherbot

This comment has been minimized.

Copy link

commented Apr 8, 2016

CL https://golang.org/cl/21677 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 8, 2016

net/http: fixed trivial go vet warnings
Updates #15177

Change-Id: I748f025461f313b5b426821ead695f90d3011a6b
Reviewed-on: https://go-review.googlesource.com/21677
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

@bradfitz bradfitz closed this Apr 10, 2016

@golang golang locked and limited conversation to collaborators Apr 10, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.