/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: use IPv4/IPv6 reserved address blocks for documentation #15228

Open
mikioh opened this Issue Apr 11, 2016 · 6 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Unplanned
2 participants
@mikioh @gopherbot
@mikioh
Contributor

mikioh commented Apr 11, 2016

There are reserved address blocks for documentation; https://tools.ietf.org/html/rfc5737 and https://tools.ietf.org/html/rfc3849. It'd be better to use them for documentation updates.

@mikioh mikioh added the Documentation label Apr 11, 2016

@mikioh mikioh added this to the Unplanned milestone Apr 11, 2016

@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented Apr 11, 2016

CL https://golang.org/cl/21642 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 12, 2016

Mikio Hara
net: make IP.{String,MarshalText} return helpful information on addre… 
…ss error

This change makes String and MarshalText methods of IP return a
hexadecial form of IP with no punctuation as part of error
notification. It doesn't affect the existing behavior of ParseIP.

Also fixes bad shadowing in ipToSockaddr and makes use of reserved
IP address blocks for documnetation.

Fixes #15052.
Updates #15228.

Change-Id: I9e9ecce308952ed5683066c3d1bb6a7b36458c65
Reviewed-on: https://go-review.googlesource.com/21642
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
1f54410
@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented May 17, 2016

CL https://golang.org/cl/23126 mentions this issue.

gopherbot pushed a commit that referenced this issue May 17, 2016

Mikio Hara
net: use IPv4/IPv6 reserved address blocks for documentation 
Also replaces google.com with golang.org in package documentation.

Updates #15228.

Change-Id: I554fa960878fa44557a522635ed412d8d7548d3f
Reviewed-on: https://go-review.googlesource.com/23126
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
495e3c6
@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented Oct 25, 2016

CL https://golang.org/cl/31950 mentions this issue.
@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented Oct 28, 2016

CL https://golang.org/cl/32146 mentions this issue.

gopherbot pushed a commit that referenced this issue Oct 28, 2016

Mikio Hara
net: use IPv4 reserved address blocks for documentation 
Updates #15228.

Change-Id: Iefdffa146703ee1c04afc2b71d9de1f0a0811f86
Reviewed-on: https://go-review.googlesource.com/32146
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
9575c58
@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented Dec 15, 2016

CL https://golang.org/cl/34431 mentions this issue.

gopherbot pushed a commit that referenced this issue Dec 15, 2016

Mikio Hara
net: fix ParseCIDR docs 
This change replaces the remaining use of "mask" with "prefix length"
and uses IPv4 reserved address blocks for documentation.

UPdates #15228.
Updates #18175.

Change-Id: I56c4f1205821c64f3195b023ad515b9d54e33f64
Reviewed-on: https://go-review.googlesource.com/34431
Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
6f5a77b
@gopherbot

This comment has been minimized.

Sign in to view

gopherbot commented May 9, 2017

CL https://golang.org/cl/42991 mentions this issue.

gopherbot pushed a commit that referenced this issue May 9, 2017

@robphoenix @bradfitz
net: fix ExampleParseCIDR IPv4 prefix length 
Issue #15228 describes that reserved address blocks should be used for
documentation purposes. This change updates the prefix length so the
IPv4 address adheres to this.

Change-Id: I237d9cce1a71f4fd95f927ec894ce53fa806047f
Reviewed-on: https://go-review.googlesource.com/42991
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
1e732ca

@mikioh mikioh added the help wanted label Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment