Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image/color, image/draw: speed up color conversions with bit twiddling #15260

Closed
josharian opened this issue Apr 12, 2016 · 2 comments
Closed

image/color, image/draw: speed up color conversions with bit twiddling #15260

josharian opened this issue Apr 12, 2016 · 2 comments

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Apr 12, 2016

CL 21910 sped up image/color BenchmarkYCbCrToRGB and image/draw BenchmarkYCbCr considerably by removing branches. Investigate doing this for other, similar conversions.

cc @martisch @nigeltao

@josharian josharian added this to the Unplanned milestone Apr 12, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 24, 2016

CL https://golang.org/cl/22411 mentions this issue.

mk0x9 pushed a commit to mk0x9/go that referenced this issue Apr 27, 2016
Apply optimizations used to speed up YCbCrToRGB from
https://go-review.googlesource.com/#/c/21910/
to RGBToYCbCr.

name             old time/op  new time/op  delta
RGBToYCbCr/0-2   6.81ns ± 0%  5.96ns ± 0%  -12.48%  (p=0.000 n=38+50)
RGBToYCbCr/Cb-2  7.68ns ± 0%  6.13ns ± 0%  -20.21%  (p=0.000 n=50+33)
RGBToYCbCr/Cr-2  6.84ns ± 0%  6.04ns ± 0%  -11.70%  (p=0.000 n=39+42)

Updates golang#15260

Change-Id: If3ea5393ae371a955ddf18ab226aae20b48f9692
Reviewed-on: https://go-review.googlesource.com/22411
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ralph Corderoy <ralph@inputplus.co.uk>
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 24, 2016

CL https://golang.org/cl/31773 mentions this issue.

@gopherbot gopherbot closed this in 2113c9a Oct 25, 2016
@golang golang locked and limited conversation to collaborators Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.