New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: make trybots post their status report upon cancelation #15263

Open
bradfitz opened this Issue Apr 12, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@bradfitz
Member

bradfitz commented Apr 12, 2016

If trybots cancel themselves due to a new patchset version or the current patchset being merged, they should post their status to Gerrit before they go away.

@bradfitz bradfitz self-assigned this Apr 12, 2016

@bradfitz bradfitz added the Builders label Apr 12, 2016

@bradfitz bradfitz added this to the Unreleased milestone Apr 12, 2016

@dmitshur

This comment has been minimized.

Member

dmitshur commented Nov 9, 2018

If trybots cancel themselves due to a new patchset version or the current patchset being merged

Do trybots still do that? I heard from @heschik that he saw trybots continue to run and send messages/emails (which were distracting) when he started a trybot, then immediately sent a newer patchset.

@bradfitz

This comment has been minimized.

Member

bradfitz commented Nov 9, 2018

Weeeellll, it's called, but ....

https://github.com/golang/build/blob/ee8efd4/cmd/coordinator/coordinator.go#L1257

// cancelBuilds run in its own goroutine and cancels this trySet's
// currently-active builds because they're no longer wanted.
func (ts *trySet) cancelBuilds() {
	// TODO(bradfitz): implement
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment