x/build/cmd/coordinator: make trybots post their status report upon cancellation

[bradfitz]

If trybots cancel themselves due to a new patchset version or the current patchset being merged, they should post their status to Gerrit before they go away.

[dmitshur]

If trybots cancel themselves due to a new patchset version or the current patchset being merged

Do trybots still do that? I heard from @heschik that he saw trybots continue to run and send messages/emails (which were distracting) when he started a trybot, then immediately sent a newer patchset.

[bradfitz]

Weeeellll, it's called, but ....

https://github.com/golang/build/blob/ee8efd4/cmd/coordinator/coordinator.go#L1257

// cancelBuilds run in its own goroutine and cancels this trySet's
// currently-active builds because they're no longer wanted.
func (ts *trySet) cancelBuilds() {
	// TODO(bradfitz): implement
}

[dmitshur]

@bradfitz Now that trySet.cancelBuilds is implemented as of CL 207842, does "trybots cancel themselves due to a new patchset version" happen? This is related to @agnivade's question in #35701 (comment).

[bradfitz]

Yes, that will happen now. (once deployed)

This issue remains a valid feature request, though.