Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: make trybots post their status report upon cancellation #15263

Open
bradfitz opened this issue Apr 12, 2016 · 4 comments
Open

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Apr 12, 2016

If trybots cancel themselves due to a new patchset version or the current patchset being merged, they should post their status to Gerrit before they go away.

@bradfitz bradfitz self-assigned this Apr 12, 2016
@bradfitz bradfitz added this to the Unreleased milestone Apr 12, 2016
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Nov 9, 2018

If trybots cancel themselves due to a new patchset version or the current patchset being merged

Do trybots still do that? I heard from @heschik that he saw trybots continue to run and send messages/emails (which were distracting) when he started a trybot, then immediately sent a newer patchset.

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Nov 9, 2018

Weeeellll, it's called, but ....

https://github.com/golang/build/blob/ee8efd4/cmd/coordinator/coordinator.go#L1257

// cancelBuilds run in its own goroutine and cancels this trySet's
// currently-active builds because they're no longer wanted.
func (ts *trySet) cancelBuilds() {
	// TODO(bradfitz): implement
}
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Nov 20, 2019

@bradfitz Now that trySet.cancelBuilds is implemented as of CL 207842, does "trybots cancel themselves due to a new patchset version" happen? This is related to @agnivade's question in #35701 (comment).

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Nov 20, 2019

Yes, that will happen now. (once deployed)

This issue remains a valid feature request, though.

@bradfitz bradfitz removed their assignment Nov 20, 2019
@bradfitz bradfitz changed the title x/build: make trybots post their status report upon cancelation x/build/cmd/coordinator: make trybots post their status report upon cancelation Nov 20, 2019
@bradfitz bradfitz changed the title x/build/cmd/coordinator: make trybots post their status report upon cancelation x/build/cmd/coordinator: make trybots post their status report upon cancellation Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants