Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: backport ppc64/ppc64le epoll_event struct fix to Go 1.6.2? #15288

Closed
bradfitz opened this issue Apr 13, 2016 · 4 comments
Closed

syscall: backport ppc64/ppc64le epoll_event struct fix to Go 1.6.2? #15288

bradfitz opened this issue Apr 13, 2016 · 4 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Apr 13, 2016

@laboger requests we backport the fix to #15135 (44f80f6, https://golang.org/cl/21582) for Go 1.6.2.

This bug is to consider that.

It only affects ppc64, and makes Docker run there.

/cc @rsc @adg @ianlancetaylor

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Apr 13, 2016

SGTM

@laboger
Copy link
Contributor

@laboger laboger commented Apr 14, 2016

Just to be clear, above where Brad says it only affects ppc64, I believe he means generically both GOARCH values for POWER, ppc64le and ppc64, not just ppc64 (big endian).

@rsc
Copy link
Contributor

@rsc rsc commented Apr 14, 2016

OK

@bradfitz bradfitz added the Release-OK label Apr 14, 2016
@bradfitz bradfitz assigned adg and unassigned rsc Apr 14, 2016
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 19, 2016

CL https://golang.org/cl/22207 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 19, 2016
The existing epoll_event structure used by many of
the epoll_* syscalls was defined incorrectly
for use with ppc64le & ppc64 in the syscall
directory.  This resulted in the caller getting
incorrect information on return from these
syscalls.  This caused failures in fsnotify as
well as builds with upstream Docker.  The
structure is defined correctly in gccgo.

This adds a pad field that is expected for
these syscalls on ppc64le, ppc64.
Fixes #15135

Fixes #15288

Change-Id: If7e8ea9eb1d1ca5182c8dc0f935b334127341ffd
Reviewed-on: https://go-review.googlesource.com/21582
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-on: https://go-review.googlesource.com/22207
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@adg adg closed this Apr 19, 2016
@adg adg added Release-Applied and removed Release-OK labels Apr 19, 2016
@golang golang locked and limited conversation to collaborators Apr 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.