Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc/trace: switch back to lean config #15302

Open
dvyukov opened this issue Apr 14, 2016 · 1 comment

Comments

@dvyukov
Copy link
Member

commented Apr 14, 2016

https://go-review.googlesource.com/#/c/22013 updates trace-viewer to newer revision (required to unbreak visualization in chrome). But trace-viewer (catapult) is broken itself at the moment:
catapult-project/catapult#2247
So the change uses full config instead of lean config. Full config works, but leads to larger html.
We need to switch back to lean config when the bug is fixed.

gopherbot pushed a commit that referenced this issue Apr 14, 2016
The old trace-viewer is broken since Chrome 49:
https://bugs.chromium.org/p/chromium/issues/detail?id=569417
It was fixed in:
catapult-project/catapult@506457c

This change updates trace-viewer to the latest version
(now it is called catapult).

This version has a bug in the lean config that we use, though:
catapult-project/catapult#2247
So use full config for now (it works, but leads to larger html).
When the bug is fixed we need to switch back to lean config (issue #15302).

Change-Id: Ifb8d782ced66e3292d81c5604039fe18eaf267c5
Reviewed-on: https://go-review.googlesource.com/22013
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz bradfitz added this to the Unplanned milestone Apr 15, 2016
@gopherbot

This comment has been minimized.

Copy link

commented Aug 24, 2017

Change https://golang.org/cl/58750 mentions this issue: misc/trace: update trace-viewer

gopherbot pushed a commit that referenced this issue Aug 25, 2017
Generated with
 github.com/catapult/tracing/bin/vulcanize_trace_viewer
catapult @ ab4d571fa

Renamed trace_viewer_lean.html to trace_viewer_full.html
to make it clear we are using the full version of trace viewer
(waiting for catapult-project/catapult#2247
to be fixed).

Update #15302

Change-Id: Ice808bb27ab79a1dec9fc863e0c5a761027ebfbe
Reviewed-on: https://go-review.googlesource.com/58750
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
@ALTree ALTree added the NeedsFix label Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.